Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Do not expose sarif and policy command #1405

Merged
merged 5 commits into from
Dec 21, 2021
Merged

✨ Do not expose sarif and policy command #1405

merged 5 commits into from
Dec 21, 2021

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Dec 20, 2021 •
edited
Loading

In order to simplify maintenance and support, we won't publicly advertise support for sarif and the score-based policy file.

  1. sarif will be used internally for the action. Currently, we run the scorecard CLI; but long-term we may have a dedicated CLI for the action.
  2. The policy file will be replaced by a setting-based policy file once we have finished separating checks from policy score-based policy calculation.

@laurentsimon laurentsimon temporarily deployed to integration-test December 20, 2021 22:30 Inactive
@laurentsimon laurentsimon temporarily deployed to integration-test December 20, 2021 22:31 Inactive
@laurentsimon laurentsimon enabled auto-merge (squash) December 20, 2021 22:32
@github-actions
Copy link

Integration tests success for
[a29a107]
(https://github.com/ossf/scorecard/actions/runs/1604254532)

@github-actions
Copy link

Integration tests success for
[74010a0]
(https://github.com/ossf/scorecard/actions/runs/1604258981)

@laurentsimon laurentsimon mentioned this pull request Dec 20, 2021
Merged
@laurentsimon laurentsimon temporarily deployed to integration-test December 20, 2021 22:39 Inactive
@github-actions
Copy link

Integration tests success for
[f2b54b3]
(https://github.com/ossf/scorecard/actions/runs/1604282020)

@laurentsimon
Copy link
Contributor Author

same error as for my other PR:

> [internal] load metadata for docker.io/library/golang@sha256:3c4de86eec9cbc619cdd72424abd88326ffcf5d813a8338a7743c55e5898734f:
------
failed to solve with frontend dockerfile.v0: failed to create LLB definition: failed to authorize: rpc error: code = Unknown desc = failed to fetch oauth token: unexpected status: 503 Service Unavailable

Re-starting but I suppose it will fail again.
cc @azeemsgoogle @naveensrinivasan

@laurentsimon laurentsimon temporarily deployed to integration-test December 21, 2021 17:04 Inactive
@github-actions
Copy link

Integration tests success for
[9faa805]
(https://github.com/ossf/scorecard/actions/runs/1607832910)

@laurentsimon laurentsimon temporarily deployed to integration-test December 21, 2021 17:42 Inactive
@github-actions
Copy link

Integration tests success for
[bf582c1]
(https://github.com/ossf/scorecard/actions/runs/1607974666)

@laurentsimon laurentsimon merged commit 3c1e814 into ossf:main Dec 21, 2021
@raghavkaul raghavkaul mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeemshaikh38 azeemshaikh38 azeemshaikh38 approved these changes

@naveensrinivasan naveensrinivasan Awaiting requested review from naveensrinivasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentsimon @azeemshaikh38